Relax failure ordering in private CAS loop helpers #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
failure-ordering
branch
2 times, most recently
from
07ae6ba
to
341f0bb
Compare
They are private functions and all closure instances only operate on the value loaded, so there is no need to synchronize the first load/failed CAS.
taiki-e
force-pushed
the
failure-ordering
branch
from
341f0bb
to
fa65c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are private functions and all closure instances only operate on the value loaded, so there is no need to synchronize the first load/failed CAS.
Unlike the public API's fetch_update, in these functions, there is no way to exit the loop until the CAS succeeds. i.e., only the value synchronized by a successful CAS with the specified order will be returned to the user.